[
https://issues.apache.org/jira/browse/MNG-7439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17511680#comment-17511680
]
Thomas Zub commented on MNG-7439:
---------------------------------
A builder would be a good choice as it also allows to move the initialization
logic from the initialize method to the builder making the setup of CliRequest
more transparent.
Do you need support for this change?
> Make fields of CliRequest protected
> -----------------------------------
>
> Key: MNG-7439
> URL: https://issues.apache.org/jira/browse/MNG-7439
> Project: Maven
> Issue Type: Improvement
> Components: Command Line, Embedding
> Affects Versions: 3.8.5
> Reporter: Thomas Zub
> Priority: Trivial
>
> Hi,
> currently the fields of
> {code:java}
> org.apache.maven.cli.CliRequest {code}
> have the default access modifier. As no setters are provided, custom
> modifications to e.g. multiModuleProjectDirectory can not be made without
> e.g. reflection or change of the system properties.
> As an implementation of CliRequest with bean properties (private fields,
> getters and setters) would be possibly a breaking change, I suggest to make
> the fields protected to enable proper subclassing for custom modifications.
> I would appreciate to make a PR if needed/wanted.
> Kind regards
> Thomas
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
