slawekjaranowski commented on code in PR #705: URL: https://github.com/apache/maven/pull/705#discussion_r847024713
########## maven-core/src/main/java/org/apache/maven/plugin/internal/ValidatingConfigurationListener.java: ########## @@ -80,18 +95,83 @@ public void notifyFieldChangeUsingReflection( String fieldName, Object value, Ob { delegate.notifyFieldChangeUsingReflection( fieldName, value, target ); - if ( mojo == target ) + if ( mojo == target && value != null ) { notify( fieldName, value ); } } private void notify( String fieldName, Object value ) { - if ( value != null ) + missingParameters.remove( fieldName ); + + if ( logger.isWarnEnabled() ) + { + warnDeprecated( fieldName, value ); + } + } + + private void warnDeprecated( String fieldName, Object value ) + { + Parameter parameter = mojoDescriptor.getParameterMap().get( fieldName ); + String deprecated = parameter.getDeprecated(); + if ( deprecated != null && !deprecated.isEmpty() ) + { + Object defaultValue = evaluateValue( parameter.getDefaultValue() ); + if ( !toString( value ).equals( toString( defaultValue ) ) ) + { + StringBuilder sb = new StringBuilder( " Parameter '" ); + sb.append( fieldName ).append( '\'' ); + if ( parameter.getExpression() != null ) + { + String userProperty = parameter.getExpression().replace( "${", "'" ).replace( '}', '\'' ); + sb.append( " (User Property " ).append( userProperty ).append( ")" ); + } + sb.append( " is deprecated. " ).append( deprecated ); Review Comment: `parameter.getDeprecated()` contains reason of depracation from plugin documentation. message will be: ``` is deprecated. Reason provided by author ... ``` please look at IT tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org