[
https://issues.apache.org/jira/browse/MWRAPPER-67?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17538433#comment-17538433
]
ASF GitHub Bot commented on MWRAPPER-67:
----------------------------------------
hazendaz commented on PR #44:
URL: https://github.com/apache/maven-wrapper/pull/44#issuecomment-1129254265
@michael-o The issue is from how the property file is read. Its reading the
entire line so it gets line feed. It really should not pick up the line feed.
I have changed the logic to fix at source of issue at least removing exact same
as I did initially. So basically the same fix just at root of the issue. The
file itself doesn't need fixed. Its irrelevent. The problem is the read from
that file picking up unnecessary content. Making the file either windows or
unix based is IMHO not the right fix.
> mvnw script does not download jar if used in git bash in windows
> ----------------------------------------------------------------
>
> Key: MWRAPPER-67
> URL: https://issues.apache.org/jira/browse/MWRAPPER-67
> Project: Maven Wrapper
> Issue Type: Bug
> Components: Maven Wrapper Scripts
> Affects Versions: 3.1.1
> Reporter: Jeremy Landis
> Priority: Minor
>
> Usage of git bash will not download the maven wrapper jar along with curl
> (probably others) due to having windows line endings in the URL (trailing).
> To ensure that is not the case, make sure to strip invalid line endings out
> before usage.
> Use case, ./mvnw in powershell will use mvnw.cmd and has no issues
> downloading. If user does same in git bash, it will fail with invalid URL
> error with curl. Using ./mvnw.cmd there will work but not natural usage. To
> ensure this simply just works for full support, trim out invalid line feeds.
> note: This only affected the download. It worked otherwise.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
