[GitHub] [maven-wrapper] hazendaz commented on a diff in pull request #44: [MWRAPPER-67] Remove invalid line endings from wrapperUrl when used with git bash with mvnw script

Tue, 17 May 2022 15:46:27 -0700 


hazendaz commented on code in PR #44:
URL: https://github.com/apache/maven-wrapper/pull/44#discussion_r875324613


##########
maven-wrapper-distribution/src/resources/mvnw:
##########
@@ -192,7 +192,8 @@ else
       
wrapperUrl="https://repo.maven.apache.org/maven2/org/apache/maven/wrapper/maven-wrapper/@@project.version@@/maven-wrapper-@@project.version@@.jar";
     fi
     while IFS="=" read key value; do
-      case "$key" in (wrapperUrl) wrapperUrl="$value"; break ;;
+      # Remove invalid line endings from value
+      case "$key" in (wrapperUrl) wrapperUrl="${value%$'\r'}"; break ;;

Review Comment:
   My testing was on Windows 10, Windows 2016 server, and RHEL 8.  So I don't 
know for sure but the logic there is posix compliant per multiple sources such 
as 
[here](https://www.ibm.com/docs/en/aix/7.1?topic=shell-parameter-substitution-in-korn-posix)
 and 
[here](https://unix.stackexchange.com/questions/389209/what-kinds-of-string-interpolation-does-posix-sh-support).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to