gnodet commented on code in PR #744:
URL: https://github.com/apache/maven/pull/744#discussion_r875636830


##########
maven-model-transform/src/main/java/org/apache/maven/model/transform/pull/BufferingParser.java:
##########
@@ -430,7 +430,7 @@ public int nextToken() throws XmlPullParserException, 
IOException
                 throw new XmlPullParserException( "already reached end of XML 
input", this, null );
             }
             int currentEvent = xmlPullParser.nextToken();
-            if ( accept() )
+            if ( disabled || accept() )

Review Comment:
   Maybe rename `disabled` to `bypass` ?
   Or `accept()` to `canYieldCurrentEvent()` ?
   Or both...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to