[jira] [Commented] (SCM-979) Replace Plexus Container Default with Sisu Plexus Shim, Java8

[ASF GitHub Bot (Jira)]

    [ 
https://issues.apache.org/jira/browse/SCM-979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17540470#comment-17540470
 ] 

ASF GitHub Bot commented on SCM-979:
------------------------------------

michael-o commented on code in PR #141:
URL: https://github.com/apache/maven-scm/pull/141#discussion_r878740436


##########
maven-scm-api/src/main/java/org/apache/maven/scm/manager/AbstractScmManager.java:
##########
@@ -44,47 +51,44 @@
 import org.apache.maven.scm.command.unedit.UnEditScmResult;
 import org.apache.maven.scm.command.update.UpdateScmResult;
 import org.apache.maven.scm.log.ScmLogger;
+import org.apache.maven.scm.log.Slf4jScmLogger;
 import org.apache.maven.scm.provider.ScmProvider;
 import org.apache.maven.scm.provider.ScmProviderRepository;
 import org.apache.maven.scm.provider.ScmUrlUtils;
 import org.apache.maven.scm.repository.ScmRepository;
 import org.apache.maven.scm.repository.ScmRepositoryException;
 import org.apache.maven.scm.repository.UnknownRepositoryStructure;
+import org.slf4j.LoggerFactory;
 
-import java.io.File;
-import java.util.ArrayList;
-import java.util.Date;
-import java.util.HashMap;
-import java.util.List;
-import java.util.Map;
-import java.util.Map.Entry;
+import static java.util.Objects.requireNonNull;
 
 /**
  * @author <a href="mailto:tryg...@inamo.no";>Trygve Laugst&oslash;l</a>
  * @author <a href="mailto:br...@apache.org";>Brett Porter</a>
  * @author <a href="mailto:eveni...@apache.org";>Emmanuel Venisse</a>
- *
  */
 public abstract class AbstractScmManager
-    implements ScmManager
+        implements ScmManager
 {
-    private Map<String, ScmProvider> scmProviders = new HashMap<String, 
ScmProvider>();
+    private final ScmLogger logger = new Slf4jScmLogger( 
LoggerFactory.getLogger( getClass() ) );
 
-    private ScmLogger logger;
+    private final Map<String, ScmProvider> scmProviders = new 
ConcurrentHashMap<>();
 
-    private Map<String, String> userProviderTypes = new HashMap<String, 
String>();
+    private final Map<String, String> userProviderTypes = new 
ConcurrentHashMap<>();
 

Review Comment:
   Concurrent because this component is a singleton?





> Replace Plexus Container Default with Sisu Plexus Shim, Java8
> -------------------------------------------------------------
>
>                 Key: SCM-979
>                 URL: https://issues.apache.org/jira/browse/SCM-979
>             Project: Maven SCM
>          Issue Type: Task
>            Reporter: Michael Osipov
>            Assignee: Tamás Cservenák
>            Priority: Major
>             Fix For: 2.0.0-M2
>
>
> Changes:
>  * make project Java8
>  * update dependencies accordingly
>  * remove any uses of deprecated Plexus APIs
>  * replace plexus-container-default with plexus-shim
>  * replace/drop PlexusLogger/ScmLogger and use SLF4J API
>  * replace use of Junit3 PlexusTestCase with Junit4 (make possible use of 
> Assume)



--
This message was sent by Atlassian Jira
(v8.20.7#820007)