[
https://issues.apache.org/jira/browse/MRESOLVER-262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17551476#comment-17551476
]
ASF GitHub Bot commented on MRESOLVER-262:
------------------------------------------
grgrzybek commented on PR #182:
URL: https://github.com/apache/maven-resolver/pull/182#issuecomment-1149629847
When running on simplest project, with modified [tracking maven
extension](https://github.com/grgrzybek/tracking-maven-extension), I have all I
need in `org.eclipse.aether.internal.impl.collect.CollectStepDataImpl`:
```
event = {org.eclipse.aether.RepositoryEvent@5325} "ARTIFACT_DOWNLOADED
log4j:log4j:pom:1.2.12
(/home/ggrzybek/sources/_testing/grgr-test-simplest/.m2/log4j/log4j/1.2.12/log4j-1.2.12.pom)
@ central (https://repo.maven.apache.org/maven2, default, releases)"
artifact: org.eclipse.aether.artifact.Artifact =
{org.eclipse.aether.artifact.DefaultArtifact@5346} "log4j:log4j:pom:1.2.12"
exceptions: java.util.List = {java.util.Collections$EmptyList@5348} size
= 0
file: java.io.File = {java.io.File@5347}
"/home/ggrzybek/sources/_testing/grgr-test-simplest/.m2/log4j/log4j/1.2.12/log4j-1.2.12.pom"
metadata: org.eclipse.aether.metadata.Metadata = null
repository: org.eclipse.aether.repository.ArtifactRepository =
{org.eclipse.aether.repository.RemoteRepository@2709} "central
(https://repo.maven.apache.org/maven2, default, releases)"
session: org.eclipse.aether.RepositorySystemSession =
{org.eclipse.aether.DefaultRepositorySystemSession@5330}
trace: org.eclipse.aether.RequestTrace =
{org.eclipse.aether.RequestTrace@5349} "log4j:log4j:pom:1.2.12 < [central
(https://repo.maven.apache.org/maven2, default, releases),
maven-default-http-blocker (http://0.0.0.0/, default, snapshots, blocked)]"
data: java.lang.Object =
{org.eclipse.aether.resolution.ArtifactRequest@5356} "log4j:log4j:pom:1.2.12 <
[central (https://repo.maven.apache.org/maven2, default, releases),
maven-default-http-blocker (http://0.0.0.0/, default, snapshots, blocked)]"
parent: org.eclipse.aether.RequestTrace =
{org.eclipse.aether.RequestTrace@5355} "log4j:log4j:jar:1.2.12 < [central
(https://repo.maven.apache.org/maven2, default, releases),
maven-default-http-blocker (http://0.0.0.0/, default, snapshots, blocked)]"
data: java.lang.Object =
{org.eclipse.aether.resolution.ArtifactDescriptorRequest@5329}
"log4j:log4j:jar:1.2.12 < [central (https://repo.maven.apache.org/maven2,
default, releases), maven-default-http-blocker (http://0.0.0.0/, default,
snapshots, blocked)]"
parent: org.eclipse.aether.RequestTrace =
{org.eclipse.aether.RequestTrace@5359}
"org.eclipse.aether.internal.impl.collect.CollectStepDataImpl@7551da2a"
data: java.lang.Object =
{org.eclipse.aether.internal.impl.collect.CollectStepDataImpl@5363}
context: java.lang.String = {@5375} "plugin"
node: org.eclipse.aether.graph.Dependency =
{org.eclipse.aether.graph.Dependency@5331} "log4j:log4j:jar:1.2.12 (compile)"
path: java.util.List = {java.util.ArrayList@5336} size = 3
0 = {org.eclipse.aether.graph.DefaultDependencyNode@5378}
"org.apache.maven.plugins:maven-compiler-plugin:jar:3.1 ()"
1 = {org.eclipse.aether.graph.DefaultDependencyNode@5379}
"org.codehaus.plexus:plexus-container-default:jar:1.5.5 (compile)"
2 = {org.eclipse.aether.graph.DefaultDependencyNode@5380}
"org.apache.xbean:xbean-reflect:jar:3.4 (compile)"
parent: org.eclipse.aether.RequestTrace =
{org.eclipse.aether.RequestTrace@5362}
"org.apache.maven.plugins:maven-compiler-plugin:jar:3.1 () -> [] < [central
(https://repo.maven.apache.org/maven2, default, releases)]"
data: java.lang.Object =
{org.eclipse.aether.collection.CollectRequest@5366}
"org.apache.maven.plugins:maven-compiler-plugin:jar:3.1 () -> [] < [central
(https://repo.maven.apache.org/maven2, default, releases)]"
parent: org.eclipse.aether.RequestTrace =
{org.eclipse.aether.RequestTrace@5365}
"org.apache.maven.plugins:maven-compiler-plugin:jar:3.1 () -> [] < [central
(https://repo.maven.apache.org/maven2, default, releases)]"
data: java.lang.Object =
{org.eclipse.aether.resolution.DependencyRequest@5370}
"org.apache.maven.plugins:maven-compiler-plugin:jar:3.1 () -> [] < [central
(https://repo.maven.apache.org/maven2, default, releases)]"
parent: org.eclipse.aether.RequestTrace =
{org.eclipse.aether.RequestTrace@5369} "Plugin
[org.apache.maven.plugins:maven-compiler-plugin]"
data: java.lang.Object = {org.apache.maven.model.Plugin@5373}
"Plugin [org.apache.maven.plugins:maven-compiler-plugin]"
parent: org.eclipse.aether.RequestTrace = null
```
Checking few of my corner cases...
> Provide contextual data in trace data for collector invoked requests
> --------------------------------------------------------------------
>
> Key: MRESOLVER-262
> URL: https://issues.apache.org/jira/browse/MRESOLVER-262
> Project: Maven Resolver
> Issue Type: Task
> Components: Resolver
> Reporter: Tamás Cservenák
> Priority: Major
> Fix For: 1.8.1
>
>
> During collection several RepositoryEvents are fired, but they does not carry
> any context related data regarding artifact collection.
> Simplest solution would be to extend RequestTrace to provide:
> * request context
> * the artifact path (from root to leaf)
> * leaf artifact being collected
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
