[
https://issues.apache.org/jira/browse/DOXIA-590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17553224#comment-17553224
]
ASF GitHub Bot commented on DOXIA-590:
--------------------------------------
michael-o commented on PR #104:
URL: https://github.com/apache/maven-doxia/pull/104#issuecomment-1153090792
> > I don't see handling for onSection.
>
> Please explain. I see no issues with the way onSection is coded (unless
the concern is that onSection does nothing if the level is greater than 5).
See here:
https://github.com/apache/maven-doxia/blob/8ef6a26a35946385ad55193a63e0180a5d5320ec/doxia-core/src/main/java/org/apache/maven/doxia/sink/impl/XhtmlBaseSink.java#L472-L484
> Either provided element class or default class gets ignored
> -----------------------------------------------------------
>
> Key: DOXIA-590
> URL: https://issues.apache.org/jira/browse/DOXIA-590
> Project: Maven Doxia
> Issue Type: Bug
> Components: Core
> Affects Versions: 1.8
> Reporter: Fred Eckertson
> Assignee: Michael Osipov
> Priority: Major
> Fix For: 2.0.0-M3, 1.11.2
>
> Attachments: image-2022-05-18-21-57-40-619.png
>
>
> The following construct is somewhat common in doxia-core
> att.addAttribute( Attribute.CLASS, "a" );
> The documentation says that basic attributes (including CLASS) are supported.
> However in cases like this either that "a" or the CLASS that was provided in
> the attributes parameter will be ignored. The correct way to do this is to
> append the provided CLASS to "a " if a CLASS attribute was provided.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
