[
https://issues.apache.org/jira/browse/MENFORCER-425?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus updated MENFORCER-425:
--------------------------------------
Description:
Currently the documentation at
https://maven.apache.org/enforcer/enforcer-api/writing-a-custom-rule.html#writing-a-custom-rule
has an example leveraging the default (i.e. compile) scope for all
dependencies.
IMHO custom rules share the classloader with the embedding m-enforcer-p and
therefore don't need "compile" scope for any of the dependencies which are
always loaded by m-enforcer-p (compare with MPLUGIN-370). Those dependencies
are
https://github.com/apache/maven-enforcer/blob/master/maven-enforcer-plugin/pom.xml#L63-L70.
That should be mentioned in the documentation for custom rules as well.
was:
Currently the documentation at
https://maven.apache.org/enforcer/enforcer-api/writing-a-custom-rule.html#writing-a-custom-rule
has an example leveraging the default (i.e. compile) scope for all
dependencies.
IMHO custom rules share the classloader with the embedding m-enforcer-p and
therefore don't need "compile" scope for any of the dependencies which are
always loaded by m-enforcer-p (compare with MPLUGIN-370). That should be
mentioned in the documentation for custom rules as well.
> Clarify class loading for custom Enforcer rules
> ------------------------------------------------
>
> Key: MENFORCER-425
> URL: https://issues.apache.org/jira/browse/MENFORCER-425
> Project: Maven Enforcer Plugin
> Issue Type: Improvement
> Components: Documentation
> Reporter: Konrad Windszus
> Priority: Major
>
> Currently the documentation at
> https://maven.apache.org/enforcer/enforcer-api/writing-a-custom-rule.html#writing-a-custom-rule
> has an example leveraging the default (i.e. compile) scope for all
> dependencies.
> IMHO custom rules share the classloader with the embedding m-enforcer-p and
> therefore don't need "compile" scope for any of the dependencies which are
> always loaded by m-enforcer-p (compare with MPLUGIN-370). Those dependencies
> are
> https://github.com/apache/maven-enforcer/blob/master/maven-enforcer-plugin/pom.xml#L63-L70.
> That should be mentioned in the documentation for custom rules as well.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
