hboutemy commented on code in PR #81: URL: https://github.com/apache/maven-assembly-plugin/pull/81#discussion_r912381465
########## src/main/java/org/apache/maven/plugins/assembly/io/URLLocation.java: ########## @@ -60,7 +60,7 @@ } /** {@inheritDoc} */ - void initFile() + protected void initFile() Review Comment: wouldn't `@Override` annotation be a better choice than `{@inheritDoc}` javadoc ########## src/main/java/org/apache/maven/plugins/assembly/io/URLLocation.java: ########## @@ -60,7 +60,7 @@ } /** {@inheritDoc} */ - void initFile() + protected void initFile() Review Comment: wouldn't `@Override` annotation be a better choice than `{@inheritDoc}` javadoc? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org