[
https://issues.apache.org/jira/browse/SCM-945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17567598#comment-17567598
]
ASF GitHub Bot commented on SCM-945:
------------------------------------
michael-o commented on code in PR #153:
URL: https://github.com/apache/maven-scm/pull/153#discussion_r922809389
##########
maven-scm-providers/maven-scm-providers-git/maven-scm-provider-gitexe/src/main/java/org/apache/maven/scm/provider/git/gitexe/command/checkin/GitCheckInCommand.java:
##########
@@ -211,11 +220,12 @@ protected CheckInScmResult executeCheckInCommand(
ScmProviderRepository repo, Sc
//
// ----------------------------------------------------------------------
- public static Commandline createPushCommandLine( GitScmProviderRepository
repository,
+ public Commandline createPushCommandLine( GitScmProviderRepository
repository,
ScmFileSet fileSet,
ScmVersion version )
Review Comment:
indent wrong
##########
maven-scm-providers/maven-scm-providers-git/maven-scm-provider-gitexe/src/main/java/org/apache/maven/scm/provider/git/gitexe/command/checkin/GitCheckInCommand.java:
##########
@@ -232,10 +242,18 @@ public static Commandline createPushCommandLine(
GitScmProviderRepository reposi
}
public static Commandline createCommitCommandLine(
GitScmProviderRepository repository, ScmFileSet fileSet,
- File messageFile )
+ File messageFile )
Review Comment:
ditto
##########
maven-scm-providers/maven-scm-providers-git/maven-scm-provider-jgit/pom.xml:
##########
@@ -45,16 +45,26 @@
<artifactId>maven-scm-provider-git-commons</artifactId>
</dependency>
<dependency>
- <groupId>org.eclipse.jgit</groupId>
- <artifactId>org.eclipse.jgit</artifactId>
- <version>4.5.4.201711221230-r</version>
+ <artifactId>plexus-interactivity-api</artifactId>
+ <groupId>org.codehaus.plexus</groupId>
+ <version>1.1</version>
<exclusions>
<exclusion>
- <groupId>commons-logging</groupId>
- <artifactId>commons-logging</artifactId>
+ <groupId>org.codehaus.plexus</groupId>
+ <artifactId>plexus-container-default</artifactId>
</exclusion>
Review Comment:
Why did you change positions? It makes reading the PR harder.
##########
maven-scm-providers/maven-scm-providers-git/maven-scm-provider-gittest/pom.xml:
##########
@@ -46,6 +46,29 @@
<groupId>org.codehaus.plexus</groupId>
<artifactId>plexus-utils</artifactId>
</dependency>
+ <!
> Support OpenSSH private keys with maven-scm-provider-jgit
> ---------------------------------------------------------
>
> Key: SCM-945
> URL: https://issues.apache.org/jira/browse/SCM-945
> Project: Maven SCM
> Issue Type: Bug
> Components: maven-scm-provider-jgit
> Affects Versions: 1.11.2
> Reporter: Konrad Windszus
> Priority: Major
>
> For SSH based authentication with private keys in the OpenSSH format the
> following error is being emitted: {{invalid privatekey: ...}}
> This is due to the use of JGit 4.5.4
> (https://github.com/apache/maven-scm/blob/c5eb2c187568809e0dc0ea9ac83031f1dcb5ad1a/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-jgit/pom.xml#L53)
> which used JSch which lacks support for those private keys. JGit 5.2 comes
> with a new SSH implementation
> (https://bugs.eclipse.org/bugs/show_bug.cgi?id=520927) and should by that
> also support OpenSSH private keys.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
