slawekjaranowski commented on code in PR #139:
URL: https://github.com/apache/maven-plugin-tools/pull/139#discussion_r956255139
##########
maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/AbstractGeneratorMojo.java:
##########
@@ -43,12 +42,6 @@
@Parameter( defaultValue = "${project}", readonly = true )
protected MavenProject project;
- /**
- * The goal prefix that will appear before the ":".
- */
- @Parameter
- protected String goalPrefix;
Review Comment:
Why you move this parameter connected stuff to `DescriptorGeneratorMojo`
We lost goalPrefix in HelpGeneratorMojo ?
##########
maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/report/PluginReport.java:
##########
@@ -195,11 +197,22 @@
* Path to {@code plugin.xml} plugin descriptor to generate the report
from.
*
* @since 3.5.1
+ * @deprecated No longer evaluated, use {@link
Review Comment:
unfinished ... docs
##########
maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/AbstractGeneratorMojo.java:
##########
@@ -88,44 +81,7 @@ public void execute()
return;
}
- if ( !"maven-plugin".equalsIgnoreCase( project.getArtifactId() )
- && project.getArtifactId().toLowerCase().startsWith( "maven-" )
- && project.getArtifactId().toLowerCase().endsWith( "-plugin" )
- && !"org.apache.maven.plugins".equals( project.getGroupId() ) )
- {
- getLog().error( LS + LS + "Artifact Ids of the format
maven-___-plugin are reserved for" + LS
- + "plugins in the Group Id
org.apache.maven.plugins" + LS
- + "Please change your artifactId to the format
___-maven-plugin" + LS
- + "In the future this error will break the
build." + LS + LS );
- }
Review Comment:
Similar - is not valid for both goals descriptor and help?
##########
pom.xml:
##########
@@ -94,9 +94,13 @@
<javaVersion>8</javaVersion>
<pluginTestingHarnessVersion>3.3.0</pluginTestingHarnessVersion>
<mavenVersion>3.2.5</mavenVersion>
+ <!-- SLF4J version must match the version exported from the mavenVersion,
+
https://github.com/apache/maven/blob/12a6b3acb947671f09b81f49094c53f426d8cea1/pom.xml#L63
-->
Review Comment:
IMHO the same major is ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
