[ 
https://issues.apache.org/jira/browse/MSHARED-1141?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov closed MSHARED-1141.
-----------------------------------
    Resolution: Fixed

Fixed with 
[cbad3daf3e0befc5f212589e9ba8109712dae5be|https://gitbox.apache.org/repos/asf?p=maven-verifier.git&a=commit&h=cbad3daf3e0befc5f212589e9ba8109712dae5be].

> ForkedLauncher#run() uses a misconception of JAVA_HOME
> ------------------------------------------------------
>
>                 Key: MSHARED-1141
>                 URL: https://issues.apache.org/jira/browse/MSHARED-1141
>             Project: Maven Shared Components
>          Issue Type: Bug
>          Components: maven-verifier
>            Reporter: Michael Osipov
>            Assignee: Michael Osipov
>            Priority: Major
>             Fix For: maven-verifier-next
>
>
> The code does:
> {noformat}
> if ( envVars == null || envVars.get( "JAVA_HOME" ) == null )
> {
>     cmd.addEnvironment( "JAVA_HOME", System.getProperty( "java.home" ) );
> } {noformat}
> This is logically wrong because {{java.home}} is not {{{}JAVA_HOME{}}}. 
> {{java.home}} points to the JRE directory which can or cannot be the 
> {{{}JAVA_HOME{}}}. This block can be removed all together and shall be eiher 
> inherited or provided by the client.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to