[
https://issues.apache.org/jira/browse/MNG-7556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17613957#comment-17613957
]
ASF GitHub Bot commented on MNG-7556:
-------------------------------------
michael-o commented on code in PR #810:
URL: https://github.com/apache/maven/pull/810#discussion_r989840590
##########
maven-core/src/main/java/org/apache/maven/internal/aether/DefaultRepositorySystemSessionFactory.java:
##########
@@ -150,6 +150,7 @@ public DefaultRepositorySystemSession newRepositorySession(
MavenExecutionReques
configProps.put( ConfigurationProperties.USER_AGENT, getUserAgent() );
configProps.put( ConfigurationProperties.INTERACTIVE,
request.isInteractiveMode() );
configProps.put( "maven.startTime", request.getStartTime() );
+ // TODO Why is this duplication necessary?
Review Comment:
Well, yes, but it will not work. I have to pass both properties to config
props since Resolver uses `ConfigUtils` which uses
`session.getConfigProperties()` only. `get(User|System)Properties()` are never
invoked from the `session`. I will change the `TODO` to a decent comment.
> Clean up notion between user properties and system properties
> -------------------------------------------------------------
>
> Key: MNG-7556
> URL: https://issues.apache.org/jira/browse/MNG-7556
> Project: Maven
> Issue Type: Task
> Reporter: Michael Osipov
> Assignee: Michael Osipov
> Priority: Major
> Fix For: 3.9.0-candidate, 4.0.0-alpha-1, 4.0.0
>
>
> For a very long time we have documented that the user can set system
> properties via {{mvn -Dfoo=bar}}, but actually those are user properties
> which are promoted to system properties and it some cases system properties
> cannot be modified *after* the JVM has been started. To properly set system
> properties there are basically two ways:
> * use {{MAVEN_OPTS}} environment variable
> * use {{.mvn/jvm.config}} file
> A third option in the future we could introduce, like other Java tools, a
> {{-J-Dfoo=bar}} option with the restriction of the the paragraph above.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
