[GitHub] [maven-dependency-plugin] gnodet commented on a diff in pull request #255: [MDEP-832] - Remove commons-collections-4

[GitBox]

gnodet commented on code in PR #255:
URL: 
https://github.com/apache/maven-dependency-plugin/pull/255#discussion_r1002059135


##########
src/main/java/org/apache/maven/plugins/dependency/analyze/AnalyzeDuplicateMojo.java:
##########
@@ -151,15 +150,9 @@ private void createMessage( Set<String> 
duplicateDependencies, StringBuilder sb,
 
     private Set<String> findDuplicateDependencies( List<Dependency> 
modelDependencies )
     {
-        List<String> modelDependencies2 = new ArrayList<>();
-        for ( Dependency dep : modelDependencies )
-        {
-            modelDependencies2.add( dep.getManagementKey() );
-        }
-
-        // @formatter:off
+        List<String> modelDependencies2 =
+                modelDependencies.stream().map( Dependency::getManagementKey 
).collect( Collectors.toList() );
         return new LinkedHashSet<>(
-                CollectionUtils.disjunction( modelDependencies2, new 
LinkedHashSet<>( modelDependencies2 ) ) );
-        // @formatter:on
+                Util.symmetricDifference( modelDependencies2, new 
LinkedHashSet<>( modelDependencies2 ) ) );

Review Comment:
   The shortest form could be:
   ```
       private Set<String> findDuplicateDependencies( List<Dependency> 
modelDependencies )
       {
           List<String> modelDependencies2 = modelDependencies.stream()
                   .map( Dependency::getManagementKey ).collect( 
Collectors.toList() );
           // remove one instance of each element from the list
           modelDependencies2.removeIf( new HashSet<>( modelDependencies2 
)::remove );
          // keep a single instance of each duplicate
           return new LinkedHashSet<>( modelDependencies2 );
       }
   ```



##########
src/main/java/org/apache/maven/plugins/dependency/analyze/AnalyzeDuplicateMojo.java:
##########
@@ -151,15 +150,9 @@ private void createMessage( Set<String> 
duplicateDependencies, StringBuilder sb,
 
     private Set<String> findDuplicateDependencies( List<Dependency> 
modelDependencies )
     {
-        List<String> modelDependencies2 = new ArrayList<>();
-        for ( Dependency dep : modelDependencies )
-        {
-            modelDependencies2.add( dep.getManagementKey() );
-        }
-
-        // @formatter:off
+        List<String> modelDependencies2 =
+                modelDependencies.stream().map( Dependency::getManagementKey 
).collect( Collectors.toList() );
         return new LinkedHashSet<>(
-                CollectionUtils.disjunction( modelDependencies2, new 
LinkedHashSet<>( modelDependencies2 ) ) );
-        // @formatter:on
+                Util.symmetricDifference( modelDependencies2, new 
LinkedHashSet<>( modelDependencies2 ) ) );

Review Comment:
   The shortest form could be:
   ```
       private Set<String> findDuplicateDependencies( List<Dependency> 
modelDependencies )
       {
           List<String> modelDependencies2 = modelDependencies.stream()
                   .map( Dependency::getManagementKey ).collect( 
Collectors.toList() );
           // remove one instance of each element from the list
           modelDependencies2.removeIf( new HashSet<>( modelDependencies2 
)::remove );
           // keep a single instance of each duplicate
           return new LinkedHashSet<>( modelDependencies2 );
       }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org