[ 
https://issues.apache.org/jira/browse/MRESOLVER-283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17629716#comment-17629716
 ] 

ASF GitHub Bot commented on MRESOLVER-283:
------------------------------------------

cstamas commented on code in PR #213:
URL: https://github.com/apache/maven-resolver/pull/213#discussion_r1015198784


##########
maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultMetadataResolver.java:
##########
@@ -83,8 +78,16 @@
     implements MetadataResolver, Service
 {
 
+    /**
+     * The count of threads to be used when resolving metadata in parallel, 
default value 4.
+     */
     private static final String CONFIG_PROP_THREADS = 
"aether.metadataResolver.threads";
 
+    /**
+     * The default value for {@link #CONFIG_PROP_THREADS}.
+     */
+    private static final int CONFIG_PROP_THREADS_DEFAULT = 4;

Review Comment:
   I kept same values as before change, this component used by default 4 
threads, no change in that area.





> Introduce resolver wide "shared" executor service
> -------------------------------------------------
>
>                 Key: MRESOLVER-283
>                 URL: https://issues.apache.org/jira/browse/MRESOLVER-283
>             Project: Maven Resolver
>          Issue Type: Improvement
>          Components: Resolver
>            Reporter: Tamas Cservenak
>            Assignee: Tamas Cservenak
>            Priority: Major
>             Fix For: 1.9.0
>
>
> More and more component in resolver does parallel processing (BF collector, 
> MD resolver, basic connector), and they all create, maintain their own 
> executor instance.
> Instead of this, create one shared service component and just reuse it 
> accross resolver.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to