[
https://issues.apache.org/jira/browse/MSHADE-434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17638422#comment-17638422
]
Chesnay Schepler edited comment on MSHADE-434 at 11/25/22 1:33 AM:
-------------------------------------------------------------------
??Why you check licenses by RAT at the one of last phase - verify.??
I don't quite remember why we run it in the verify phase.
??Change phase of RAT to standard validate will help you.??
We can certainly work around this particular issue; that's not really the
problem at hand.
What I worry about is that this may also affect other plugins in some way that
isn't as obvious.
was (Author: zentol):
??Why you check licenses by RAT at the one of last phase - verify.??
I don't quite remember why we run it in the verify phase.
??Change phase of RAT to standard validate will help you.??
We can certainly work around this particular issue; that's not really the
problem at hand.
What I worry about is that this also affects other plugins in some way that
isn't as obvious.
> Strange side-effect on rat-plugin
> ---------------------------------
>
> Key: MSHADE-434
> URL: https://issues.apache.org/jira/browse/MSHADE-434
> Project: Maven Shade Plugin
> Issue Type: Bug
> Affects Versions: 3.3.0
> Reporter: Chesnay Schepler
> Priority: Major
>
> When upgrading the shade-plugin from 3.2.4 to 3.3.0, without changing
> anything else, the Apache Flink builds are getting failed by the rat-plugin,
> complaining about a number of files in the root target/ directory.
> These files do exist, but are usually excluded by the plugin.
> For some reason upgrading the shade-plugin is changing this behavior.
> {code:java}
> [WARNING] Files with unapproved licenses:
> /home/chesnay/dev/repos/flink/flink/target/rat.txt
> /home/chesnay/dev/repos/flink/flink/target/checkstyle-result.xml
> /home/chesnay/dev/repos/flink/flink/target/checkstyle-cachefile
> {code}
> This is reeeeally strange, and were wondering if you guys have any ideas for
> what could going on here.
> Interestingly enough explicitly listing these files (e.g., {{**/rat.txt}})
> results in them being excluded again.
> This happened with Java 8 + Maven 3.2.5 and Java 11 + Maven 3.8.6 and is 100%
> reproducible.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
