kwin commented on code in PR #198: URL: https://github.com/apache/maven-enforcer/pull/198#discussion_r1050795396
########## enforcer-rules/src/main/java/org/apache/maven/plugins/enforcer/AbstractBanDependencies.java: ########## @@ -18,22 +18,15 @@ */ Review Comment: API here just means it is exported via the class path to all custom rules and can be accessed and extended. It doesn't say anything about design.... Potentially that affects every rule which is not a final class (because there is no limited visibility) but I wouldn't go that far to say that it is strictly necessary to keep backwards compatibility in those classes but at least for abstract public classes I would say we unfortunately need to be backwards compatible here (so first deprecate and only finally remove in m-enforcer-p 4.0.0) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
