[
https://issues.apache.org/jira/browse/MNG-7352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17651706#comment-17651706
]
ASF GitHub Bot commented on MNG-7352:
-------------------------------------
Bananeweizen commented on PR #934:
URL: https://github.com/apache/maven/pull/934#issuecomment-1364178304
To me this looks good. Regarding the question how this is used:
https://github.com/eclipse-tycho/tycho/blob/4e3f31c4411156c86a8571e353efde898cf258ea/tycho-compiler-plugin/src/main/java/org/eclipse/tycho/compiler/AbstractOsgiCompilerMojo.java#L777
shows Tycho calling `getJavaHome()` on that class, which is not available in
the super interface, otherwise we wouldn't need to look at this class.
I'm not sure whether I should also comment in the Jira issue (is there any
transition of Maven projects to Github ongoing or was it always this kind of
mixed for issues and pull requests?)
> org.apache.maven.toolchain.java.JavaToolchainImpl should be public
> ------------------------------------------------------------------
>
> Key: MNG-7352
> URL: https://issues.apache.org/jira/browse/MNG-7352
> Project: Maven
> Issue Type: Bug
> Components: Core
> Affects Versions: 3.8.4
> Reporter: Michael Keppler
> Assignee: Michael Osipov
> Priority: Trivial
> Fix For: 3.8.x-candidate, 3.9.0-candidate, 4.0.x-candidate,
> waiting-for-feedback
>
>
> org.apache.maven.toolchain.java.JavaToolchainImpl has been created as
> replacement for the now deprecated
> org.apache.maven.toolchain.java.DefaultJavaToolChain.
> However, the deprecated class was public, the new one isn't. That makes it
> impossible to follow the deprecation note to use the new class (outside of
> Maven core). I'm trying to fix this deprecation in Maven Tycho.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
