psiroky commented on code in PR #205:
URL: https://github.com/apache/maven-enforcer/pull/205#discussion_r1057972238
##########
maven-enforcer-plugin/src/main/java/org/apache/maven/plugins/enforcer/EnforceMojo.java:
##########
@@ -134,9 +147,7 @@ public void execute() throws MojoExecutionException {
Log log = this.getLog();
PluginParameterExpressionEvaluator evaluator = new
PluginParameterExpressionEvaluator(session, mojoExecution);
- if (commandLineRules != null && commandLineRules.length > 0) {
- this.rules = createRulesFromCommandLineOptions();
- }
+ this.rules = determineRulesToExecute();
Review Comment:
Yeah, maybe I am too paranoid. I was thinking if someone is doing e.g. `new
EnforcerMojo().getRules()` then removing the getter would break that. Good
question is how much sense does that even make and if this is anything that we
should care about.
If you agree I would remove the getter then.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
