[
https://issues.apache.org/jira/browse/DOXIA-684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652547#comment-17652547
]
ASF GitHub Bot commented on DOXIA-684:
--------------------------------------
michael-o commented on code in PR #133:
URL: https://github.com/apache/maven-doxia/pull/133#discussion_r1058501071
##########
doxia-modules/doxia-module-markdown/pom.xml:
##########
@@ -51,19 +51,57 @@ under the License.
</contributor>
</contributors>
+ <properties>
+ <flexmark.version>0.42.14</flexmark.version>
Review Comment:
master is at
https://github.com/apache/maven-doxia/blob/master/doxia-modules/doxia-module-markdown/pom.xml#L67
`0.62.2`, 1.11.x requires a different version though
##########
doxia-modules/doxia-module-markdown/pom.xml:
##########
@@ -51,19 +51,57 @@ under the License.
</contributor>
</contributors>
+ <properties>
+ <flexmark.version>0.42.14</flexmark.version>
Review Comment:
I think we should use the camelCase approach for version properties
everywhere now: `flexmarkVersion`
> replace flexmark-all dependency with core + only the used extensions
> --------------------------------------------------------------------
>
> Key: DOXIA-684
> URL: https://issues.apache.org/jira/browse/DOXIA-684
> Project: Maven Doxia
> Issue Type: Improvement
> Components: Module - Markdown
> Affects Versions: 1.11.1, 2.0.0-M4
> Reporter: Herve Boutemy
> Priority: Major
> Fix For: 1.11.2, 2.0.0-M5
>
>
> flexmark-all is easy to add to dependency, but downloads a bunch of unused
> extensions
> doing the effort to explicitely list only the used extensions will reduce
> Maven downloading some parts of the universe
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
