slawekjaranowski commented on code in PR #216:
URL: https://github.com/apache/maven-enforcer/pull/216#discussion_r1060884704
##########
maven-enforcer-plugin/src/main/java/org/apache/maven/plugins/enforcer/internal/EnforcerRuleManager.java:
##########
@@ -25,33 +25,52 @@
import java.util.ArrayList;
import java.util.List;
+import java.util.Objects;
-import org.apache.maven.enforcer.rule.api.EnforcerRule;
+import org.apache.maven.enforcer.rule.api.EnforcerRuleBase;
import org.apache.maven.execution.MavenSession;
import org.apache.maven.plugin.MojoExecution;
import org.apache.maven.plugin.PluginParameterExpressionEvaluator;
+import org.apache.maven.plugins.enforcer.EnforcerRuleManagerException;
+import org.codehaus.plexus.PlexusContainer;
import org.codehaus.plexus.classworlds.realm.ClassRealm;
import
org.codehaus.plexus.component.configurator.ComponentConfigurationException;
import org.codehaus.plexus.component.configurator.ComponentConfigurator;
import
org.codehaus.plexus.component.configurator.expression.ExpressionEvaluator;
+import
org.codehaus.plexus.component.repository.exception.ComponentLookupException;
import org.codehaus.plexus.configuration.PlexusConfiguration;
/**
* Manage enforcer rules.
+ *
+ * @author Slawomir Jaranowski
+ * @since 3.2.0
*/
@Named
@Singleton
public class EnforcerRuleManager {
- @Inject
- private Provider<MavenSession> sessionProvider;
+ private final Provider<MavenSession> sessionProvider;
- @Inject
- private Provider<MojoExecution> mojoExecutionProvider;
+ private final Provider<MojoExecution> mojoExecutionProvider;
+
+ private final ComponentConfigurator componentConfigurator;
+
+ private final PlexusContainer plexusContainer;
Review Comment:
Even in new Api we use `PlexusContainer`
https://github.com/apache/maven/blob/master/maven-core/src/main/java/org/apache/maven/internal/impl/DefaultLookup.java
So now I don't see another way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
