ajarmoniuk commented on code in PR #169:
URL:
https://github.com/apache/maven-compiler-plugin/pull/169#discussion_r1081577830
##########
src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java:
##########
@@ -1814,29 +1810,26 @@ private List<String> resolveProcessorPathEntries()
ArtifactHandler handler =
artifactHandlerManager.getArtifactHandler( coord.getType() );
Artifact artifact = new DefaultArtifact(
- coord.getGroupId(),
- coord.getArtifactId(),
- VersionRange.createFromVersionSpec( coord.getVersion() ),
- Artifact.SCOPE_RUNTIME,
- coord.getType(),
- coord.getClassifier(),
- handler,
- false );
-
- ArtifactResolutionRequest request = new
ArtifactResolutionRequest()
- .setArtifact( artifact )
- .setResolveRoot( true )
- .setResolveTransitively( true )
- .setLocalRepository(
session.getLocalRepository() )
- .setRemoteRepositories(
project.getRemoteArtifactRepositories() );
-
- ArtifactResolutionResult resolutionResult =
repositorySystem.resolve( request );
-
- resolutionErrorHandler.throwErrors( request, resolutionResult
);
-
- for ( Artifact resolved : resolutionResult.getArtifacts() )
+ coord.getGroupId(),
+ coord.getArtifactId(),
+ coord.getClassifier(),
+ handler.getExtension(),
+ coord.getVersion()
+ );
+
+ CollectRequest collectRequest = new CollectRequest( new
Dependency( artifact, JavaScopes.RUNTIME ),
+ project.getRemoteProjectRepositories() );
+ DependencyRequest dependencyRequest = new DependencyRequest();
+ dependencyRequest.setCollectRequest( collectRequest );
+ DependencyResult dependencyResult =
repositorySystem.resolveDependencies(
+ session.getRepositorySession(), dependencyRequest );
+
+ for ( ArtifactResult resolved :
dependencyResult.getArtifactResults() )
{
- elements.add( resolved.getFile().getAbsolutePath() );
+ if ( resolved.getArtifact() != null &&
resolved.getArtifact().getFile() != null )
+ {
+ elements.add(
resolved.getArtifact().getFile().getAbsolutePath() );
+ }
Review Comment:
Your comment in the other PR is correct. So, explicit checking is not
necessary. In addition, ArtifactResult::getExceptions (if you catch a
DependencyResolutionException) will contain the list of all gathered exceptions
(if there are more than one).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
