[
https://issues.apache.org/jira/browse/MWRAPPER-81?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17679221#comment-17679221
]
ASF GitHub Bot commented on MWRAPPER-81:
----------------------------------------
ArloL commented on code in PR #67:
URL: https://github.com/apache/maven-wrapper/pull/67#discussion_r1082774153
##########
maven-wrapper-distribution/src/resources/mvnw:
##########
@@ -160,7 +160,7 @@ find_maven_basedir() {
# concatenates all lines of a file
concat_lines() {
if [ -f "$1" ]; then
- echo "$(tr -s '\n' ' ' < "$1")"
+ echo "$(tr -s '\r\n' ' ' < "$1")"
Review Comment:
I've updated the PR :)
> mvnw does not remove return chars from jvm.config
> -------------------------------------------------
>
> Key: MWRAPPER-81
> URL: https://issues.apache.org/jira/browse/MWRAPPER-81
> Project: Maven Wrapper
> Issue Type: Bug
> Components: Maven Wrapper Scripts
> Affects Versions: 3.1.1
> Reporter: Arlo Louis O'Keeffe
> Priority: Minor
>
> When the jvm.config contains return characters (\r) in addition to newlines
> (\n) e.g. on Windows the mvnw script does not remove those.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
