oehme commented on code in PR #784:
URL: https://github.com/apache/maven-mvnd/pull/784#discussion_r1097292232
##########
daemon/src/main/java/org/apache/maven/cli/DaemonMavenCli.java:
##########
@@ -473,6 +472,7 @@ DefaultPlexusContainer container() throws Exception {
List<File> extClassPath = Stream.of(
Environment.MVND_EXT_CLASSPATH.asString().split(","))
+ .filter(s -> s != null && !s.isEmpty())
Review Comment:
The missing empty filter here lead to the empty String being added to the
extClassPath list, which made the classloader structure slightly different from
vanilla Maven in some scenarios. Not a big deal in practice, but it broke some
of our tests, so I decided to fix it for consistency :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
