[ 
https://issues.apache.org/jira/browse/MBUILDCACHE-46?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17692835#comment-17692835
 ] 

ASF GitHub Bot commented on MBUILDCACHE-46:
-------------------------------------------

atsteffen commented on code in PR #43:
URL: 
https://github.com/apache/maven-build-cache-extension/pull/43#discussion_r1116098085


##########
src/main/java/org/apache/maven/buildcache/xml/CacheConfigImpl.java:
##########
@@ -452,7 +453,9 @@ public boolean isEnabled() {
     @Override
     public boolean isRemoteCacheEnabled() {
         checkInitializedState();
-        return getRemote().getUrl() != null && getRemote().isEnabled();
+        return getRemote().getUrl() != null
+                && Boolean.parseBoolean(System.getProperty(

Review Comment:
   Thanks!  I went ahead and updated a couple other Boolean.getProperty(..) 
methods as those also go to the system properties.





> Add maven.build.cache.remote.enabled parameter
> ----------------------------------------------
>
>                 Key: MBUILDCACHE-46
>                 URL: https://issues.apache.org/jira/browse/MBUILDCACHE-46
>             Project: Maven Build Cache Extension
>          Issue Type: Improvement
>            Reporter: Olivier Lamy
>            Assignee: Olivier Lamy
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.0.1
>
>
> PR https://github.com/apache/maven-build-cache-extension/pull/43



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to