[ https://issues.apache.org/jira/browse/MBUILDCACHE-46?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17696967#comment-17696967 ]
ASF GitHub Bot commented on MBUILDCACHE-46: ------------------------------------------- atsteffen commented on code in PR #43: URL: https://github.com/apache/maven-build-cache-extension/pull/43#discussion_r1126456733 ########## src/main/java/org/apache/maven/buildcache/xml/CacheConfigImpl.java: ########## @@ -597,4 +597,15 @@ private String getProperty(String key, String defaultValue) { } return value; } + + private boolean getProperty(String key, boolean defaultValue) { + String value = session.getUserProperties().getProperty(key); + if (value == null) { + value = session.getSystemProperties().getProperty(key); + if (value == null) { + return defaultValue; + } + } + return Boolean.parseBoolean(value); Review Comment: This could be accomplished any number of ways, but I decided to go with the micro-optimized form that does not require a string parse to handle the default case. > Add maven.build.cache.remote.enabled parameter > ---------------------------------------------- > > Key: MBUILDCACHE-46 > URL: https://issues.apache.org/jira/browse/MBUILDCACHE-46 > Project: Maven Build Cache Extension > Issue Type: Improvement > Reporter: Olivier Lamy > Assignee: Olivier Lamy > Priority: Major > Labels: pull-request-available > Fix For: 1.0.1 > > > PR https://github.com/apache/maven-build-cache-extension/pull/43 -- This message was sent by Atlassian Jira (v8.20.10#820010)