kwin commented on code in PR #146:
URL: https://github.com/apache/maven-doxia/pull/146#discussion_r1118085895
##########
doxia-modules/doxia-module-markdown/src/test/java/org/apache/maven/doxia/module/markdown/MarkdownSinkTest.java:
##########
@@ -212,24 +214,23 @@ protected String getDivisionBlock(String text) {
/** {@inheritDoc} */
protected String getVerbatimSourceBlock(String text) {
- return EOL
- + EOL
- + MarkdownMarkup.VERBATIM_START_MARKUP
+ return MarkdownMarkup.VERBATIM_START_MARKUP
+ EOL
+ text
+ EOL
+ MarkdownMarkup.VERBATIM_START_MARKUP
+ + EOL
+ EOL;
}
/** {@inheritDoc} */
protected String getHorizontalRuleBlock() {
- return EOL + MarkdownMarkup.HORIZONTAL_RULE_MARKUP + EOL;
+ return MarkdownMarkup.HORIZONTAL_RULE_MARKUP + EOL + EOL;
}
/** {@inheritDoc} */
protected String getPageBreakBlock() {
- return EOL + MarkdownMarkup.PAGE_BREAK_MARKUP + EOL;
+ return "";
Review Comment:
I agree with @elharo. Using a constant for this seems like overkill.
##########
doxia-modules/doxia-module-markdown/src/test/java/org/apache/maven/doxia/module/markdown/MarkdownSinkTest.java:
##########
@@ -144,21 +149,18 @@ protected String getFooterBlock() {
/** {@inheritDoc} */
protected String getListBlock(String item) {
- return EOL + EOL + Markup.SPACE + "" +
MarkdownMarkup.LIST_UNORDERED_ITEM_START_MARKUP + "" + Markup.SPACE
- + getEscapedText(item) + EOL + EOL;
+ return MarkdownMarkup.LIST_UNORDERED_ITEM_START_MARKUP + "" +
Markup.SPACE + getEscapedText(item) + EOL + EOL;
}
/** {@inheritDoc} */
protected String getNumberedListBlock(String item) {
- return EOL + EOL + Markup.SPACE + ""
- + MarkdownMarkup.LIST_ORDERED_ITEM_START_MARKUP + ""
- + Markup.SPACE + getEscapedText(item) + EOL + EOL;
+ return MarkdownMarkup.LIST_ORDERED_ITEM_START_MARKUP + "" +
Markup.SPACE + getEscapedText(item) + EOL + EOL;
}
/** {@inheritDoc} */
protected String getDefinitionListBlock(String definum, String definition)
{
- return EOL + EOL + Markup.SPACE + "" + Markup.LEFT_SQUARE_BRACKET +
definum + Markup.RIGHT_SQUARE_BRACKET + ""
- + Markup.SPACE + definition + EOL + EOL;
+ return "<dl>" + EOL + "<dt>" + getEscapedText(definum) + "</dt>" + EOL
+ "<dd>" + getEscapedText(definition)
Review Comment:
Done in
https://github.com/apache/maven-doxia/pull/146/commits/c49775264627b41daa3b17e90f9d72a0b0d9c218.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
