michael-o commented on code in PR #1015:
URL: https://github.com/apache/maven/pull/1015#discussion_r1128739066
##########
maven-settings-builder/src/main/java/org/apache/maven/settings/validation/DefaultSettingsValidator.java:
##########
@@ -60,7 +59,7 @@ public void validate(Settings settings,
SettingsProblemCollector problems) {
for (int i = 0; i < pluginGroups.size(); i++) {
String pluginGroup = pluginGroups.get(i).trim();
- if (StringUtils.isBlank(pluginGroup)) {
+ if (pluginGroup.trim().isEmpty()) {
addViolation(
problems, Severity.ERROR,
"pluginGroups.pluginGroup[" + i + "]", null, "must not be empty");
} else if (!ID_REGEX.matcher(pluginGroup).matches()) {
Review Comment:
I am included to drop the entire trim. The rest of the class does not trim
at all. It should be consistent throughout elements.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
