gnodet commented on code in PR #1015:
URL: https://github.com/apache/maven/pull/1015#discussion_r1133104328
##########
maven-settings-builder/src/main/java/org/apache/maven/settings/validation/DefaultSettingsValidator.java:
##########
@@ -58,9 +57,9 @@ public void validate(Settings settings,
SettingsProblemCollector problems) {
if (pluginGroups != null) {
for (int i = 0; i < pluginGroups.size(); i++) {
- String pluginGroup = pluginGroups.get(i).trim();
+ String pluginGroup = pluginGroups.get(i);
- if (StringUtils.isBlank(pluginGroup)) {
+ if (pluginGroup == null || pluginGroup.isEmpty()) {
Review Comment:
Should that be
```
validateStringNotEmpty(problems, "pluginGroups.pluginGroup["
+ i + "]", pluginGroup, null);
```
to be homogeneous with the lines below ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
