[ https://issues.apache.org/jira/browse/MNG-7727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17698971#comment-17698971 ]
Guillaume Nodet commented on MNG-7727: -------------------------------------- We can't remove the whole package, but we can remove the interface along with the component. I think it's better because it will throw a ClassNotFoundException instead of a cryptic sisu/plexus provisioning error, which would be harder to diagnose. > Remove the implementation of DefaultMavenProfilesBuilder#buildProfiles > ---------------------------------------------------------------------- > > Key: MNG-7727 > URL: https://issues.apache.org/jira/browse/MNG-7727 > Project: Maven > Issue Type: Bug > Reporter: Guillaume Nodet > Assignee: Guillaume Nodet > Priority: Major > Fix For: 4.0.0-alpha-5 > > > Going through the usage of the plexus-utils {{ReaderFactory}} in maven, the > {{DefaultMavenProfilesBuilder#buildProfiles}} method suffers from possible > encoding/BOM problems. Removing this code would get rid of a few > dependencies on plexus-utils. > This class is deprecated since 2009. I don't think there are any code > actually using this method, and such usage would have to deal with a null > return value anyway, so it should be perfectly safe to just always return > null. > See https://github.com/apache/maven/pull/1044 -- This message was sent by Atlassian Jira (v8.20.10#820010)