gnodet commented on code in PR #1061:
URL: https://github.com/apache/maven/pull/1061#discussion_r1152023745
##########
maven-core/src/main/java/org/apache/maven/execution/DefaultMavenExecutionRequest.java:
##########
@@ -1051,16 +1057,44 @@ public MavenExecutionRequest setToolchains(Map<String,
List<ToolchainModel>> too
return this;
}
+ @Deprecated
@Override
public void setMultiModuleProjectDirectory(File directory) {
this.multiModuleProjectDirectory = directory;
}
+ @Deprecated
@Override
public File getMultiModuleProjectDirectory() {
return multiModuleProjectDirectory;
}
+ @Override
+ public Path getRootdir() {
+ if (rootdir == null) {
+ throw new IllegalArgumentException("Unable to find the root
directory. "
Review Comment:
But we can't know early if someone uses the `${session.rootdir}`or
`${rootdir}` in the model, profile activation or a plugin configuration. If we
fail early, this will mean that all projects will be required to add this
`.mvn` direction, whether they actually use it or not. Note that we already
have a warning if this directory does not exist.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
