gnodet commented on code in PR #1061:
URL: https://github.com/apache/maven/pull/1061#discussion_r1151777611
##########
maven-core/src/main/java/org/apache/maven/plugin/PluginParameterExpressionEvaluator.java:
##########
@@ -165,7 +165,11 @@ public Object evaluate(String expr, Class<?> type) throws
ExpressionEvaluationEx
MojoDescriptor mojoDescriptor = mojoExecution.getMojoDescriptor();
- if ("localRepository".equals(expression)) {
+ if ("rootdir".equals(expression) ||
"session.rootdir".equals(expression)) {
+ value = session.getRootdir();
+ } else if ("topdir".equals(expression) ||
"session.topdir".equals(expression)) {
+ value = session.getTopdir();
Review Comment:
@michael-o fwiw, the addition of `rootdir` and `topdir` was done to be in
line with `basedir`, so maybe we should deprecate that one ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
