michael-o commented on code in PR #81:
URL:
https://github.com/apache/maven-dependency-analyzer/pull/81#discussion_r1155001476
##########
src/main/java/org/apache/maven/shared/dependency/analyzer/ClassFileVisitorUtils.java:
##########
@@ -99,7 +97,8 @@ private static void acceptJar( URL url, ClassFileVisitor
visitor )
// ignore files like package-info.class and module-info.class
if ( name.endsWith( ".class" ) && name.indexOf( '-' ) == -1 )
{
- visitClass( name, in, visitor );
+ // Even on Windows Jars use / as the separator character
Review Comment:
The comment is redundant and wrong because this has nothing to do with
Windows. REad the PKZIP implementation note: separators are always foward
slashes regarding of the OS.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
