[ https://issues.apache.org/jira/browse/MNG-7038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17709734#comment-17709734 ]
ASF GitHub Bot commented on MNG-7038: ------------------------------------- gnodet commented on PR #1061: URL: https://github.com/apache/maven/pull/1061#issuecomment-1500435764 > > > I do not feel very comfortable to add runtime information into a static model. This does not feel right. Maybe we should just require `.mvn` to be present now, period? > > > > > > I'll let you discuss with @rmannibucau about that, because that's precisely the very point he disagree with... > > My feeling is that hes the only one disagreeing here, so maybe we can not make everyone happy ;-) Beside that i find "root" confusing if it is only used to define a path but has no other meaning. > > Also as an excerpt from the discussion, I think that almost all use-cases would better to have a property that has the full path of the current **pom.xml file** (!). > > So lets say I have a parent `pom.xml` and I use the property `${this.location}` it should always resolve to the path of the parent pom even if used in a child at any level. Thats simple and can be used independent of the project structure. Some of the use cases involve arguments interpolation, so this has to be done _very early_ in the process. Also, I disagree that this is _weird_ somehow. I think it's actually mapping quite well with the property `isRootProject()` which has already been added to the `Project`, and actually nicely reflects the correct semantic and what we're looking for. > Introduce public property to point to a root directory of (multi-module) > project > -------------------------------------------------------------------------------- > > Key: MNG-7038 > URL: https://issues.apache.org/jira/browse/MNG-7038 > Project: Maven > Issue Type: Improvement > Reporter: Envious Guest > Priority: Major > Fix For: Issues to be reviewed for 4.x > > > This is a request to expose a property *maven.multiModuleProjectDirectory* > which is currently internal (or introduce a brand new one with analogous > functionality). > * For a single-module project, its value should be same as *project.basedir* > * For multi-module project, its value should point to a project.basedir of a > root module > Example: > multi-module // located at /home/me/sources > +- module-a > +- module B > Sample multi-module/pom.xml: > {{<project>}} > {{ <parent>}} > {{ <groupId>com.acme</groupId>}} > {{ <artifactId>corp-parent</artifactId>}} > {{ <version>1.0.0-RELEASE</version>}} > {{ </parent>}} > {{ <groupId>com.acme</groupId>}} > {{ <artifactId>multi-module</artifactId>}} > {{ <version>0.5.2-SNAPSHOT</version>}} > {{ <modules>}} > {{ <module>module-a</module>}} > {{ <module>module-b</module>}} > {{ </modules>}} > {{</project>}} > The property requested should return /home/me/sources/multi-module, > regardless of whether it's referenced in any of the child modules (module-a, > module-b) or in multi-module. > Note that multi-module itself has parent (e.g. installed in a local > repository), so the new property should be smart enough to detect it and > still point to /home/me/sources/multi-module instead of the local repository > where the corp-parent is installed. > The use-case for such a property could be to have a directory for combined > report of static analysis tools. Typical example - jacoco combined coverage > reports. -- This message was sent by Atlassian Jira (v8.20.10#820010)