cstamas commented on code in PR #1098:
URL: https://github.com/apache/maven/pull/1098#discussion_r1183365054
##########
maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java:
##########
@@ -526,8 +578,39 @@ private void commands(CliRequest cliRequest) {
// Needed to make this method package visible to make writing a unit test
possible
// Maybe it's better to move some of those methods to separate class (SoC).
- void properties(CliRequest cliRequest) {
- populateProperties(cliRequest.commandLine,
cliRequest.systemProperties, cliRequest.userProperties);
+ void properties(CliRequest cliRequest) throws ExitException {
+ try {
+ populateProperties(cliRequest, cliRequest.systemProperties,
cliRequest.userProperties);
+
+ StringSearchInterpolator interpolator =
Review Comment:
As I see in maven codebase use of StringSearch vs Regexp interpolator is
4:5, this PR (if merged as is) will make it 5:5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
