[
https://issues.apache.org/jira/browse/MNG-7774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17719222#comment-17719222
]
ASF GitHub Bot commented on MNG-7774:
-------------------------------------
cstamas commented on PR #1098:
URL: https://github.com/apache/maven/pull/1098#issuecomment-1534339709
> Does this actually supersede #1062?
No, that one is for master and builds on top of already present new mvn4
features not present in 3.9.x. This PR is for 3.9.x and "mildly follows" the
one you refer to, with reduced functionalities. For example, that one uses
`RootLocator` (already on master) while we have no such thing. Master also uses
two strategies to identify "root", but it requires consumer POM feature, again
not available here, etc. This PR provides "minimum viable change" to provide in
3.9.x:
* config and command line interpolation
* two new properties (but for interpolation ONLY), unlike on master, where
these two bubble up to session and project
* the UT is intentionally 1:1 (so it IS copy pasted from referenced PR)
> Maven config and command line interpolation
> -------------------------------------------
>
> Key: MNG-7774
> URL: https://issues.apache.org/jira/browse/MNG-7774
> Project: Maven
> Issue Type: Task
> Components: Command Line
> Reporter: Tamas Cservenak
> Assignee: Tamas Cservenak
> Priority: Major
> Fix For: 3.9.2
>
>
> Note: this issue "mildly follows" functionality done in Maven 4 as part of
> MNG-7038 and MNG-6303, with partial implementation only (is not full
> back-port), hence "mild introduction".
> Rationale: many new resolver features are akin to be able to store their
> configuration and input along SCM tracked Maven project sources. Sadly,
> currently this is not possible. The two issues targeting Maven4 (MNG-7038 and
> MNG-6303) with introduction of session and project "topDirectory" and
> "rootDirectory" properties solve this. Still, Maven 3.9.x does not need all
> of this.
> So, idea is following:
> * extend MavenCli to interpolate Maven arguments
> * introduce two special properties {{session.rootDirectory}} and
> {{session.topDirectory}} in interpolation. They are special, as they may not
> be defined, and IF they are not defined, their use in Maven argument
> interpolation causes error (Maven will not boot).
> * limit the use of the two new properties to Maven CLI interpolation only.
> This makes projects relying on Maven CLI interpolation "permeable" between
> Maven 3.9.x and Maven 4, while all the whistle and bells (exposing this via
> session or project) will be available in Maven 4 only.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
