[GitHub] [maven] elharo commented on a diff in pull request #1099: [MNG-7714] Fixed a scenario in version sorting where sp1 is less than final

[via GitHub]

elharo commented on code in PR #1099:
URL: https://github.com/apache/maven/pull/1099#discussion_r1193676388


##########
maven-artifact/src/main/java/org/apache/maven/artifact/versioning/ComparableVersion.java:
##########
@@ -199,6 +202,7 @@ public int compareTo(Item item) {
                     return -1;
 
                 case STRING_ITEM:
+                case COMBINATION_ITEM:

Review Comment:
   STRING_ITEM should have its own return. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org