[ 
https://issues.apache.org/jira/browse/MRESOLVER-365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17728348#comment-17728348
 ] 

ASF GitHub Bot commented on MRESOLVER-365:
------------------------------------------

michael-o commented on code in PR #294:
URL: https://github.com/apache/maven-resolver/pull/294#discussion_r1213118257


##########
maven-resolver-named-locks-hazelcast/pom.xml:
##########
@@ -39,21 +39,23 @@
   <dependencies>
     <dependency>
       <groupId>org.apache.maven.resolver</groupId>
-      <artifactId>maven-resolver-api</artifactId>
+      <artifactId>maven-resolver-named-locks</artifactId>
+      <scope>provided</scope>
     </dependency>
     <dependency>
-      <groupId>org.apache.maven.resolver</groupId>
-      <artifactId>maven-resolver-named-locks</artifactId>
+      <groupId>org.slf4j</groupId>
+      <artifactId>slf4j-api</artifactId>
+      <scope>provided</scope>
     </dependency>
     <dependency>
       <groupId>com.hazelcast</groupId>
       <artifactId>hazelcast</artifactId>
-      <version>5.1.4</version>
+      <version>5.3.0</version>
     </dependency>
     <dependency>
       <groupId>javax.inject</groupId>
       <artifactId>javax.inject</artifactId>
-      <optional>true</optional>
+      <scope>provided</scope>
     </dependency>

Review Comment:
   This I don't fully understand, what if used outside of Maven, will this 
still work?





> Upgrade dependencies
> --------------------
>
>                 Key: MRESOLVER-365
>                 URL: https://issues.apache.org/jira/browse/MRESOLVER-365
>             Project: Maven Resolver
>          Issue Type: Dependency upgrade
>            Reporter: Tamas Cservenak
>            Assignee: Tamas Cservenak
>            Priority: Major
>             Fix For: 1.9.11
>
>
> Changes:
>  * (transport-http) httpClient 4.5.14
>  * (transport-http) httpCore 4.4.16
>  * (transport-http, test-only) Jetty 9.4.51
>  * (transport-wagon) wagon 3.5.3
>  * (transport-wagon) plexus-classworlds 2.7.0
>  * (named-locks-hazelcast) hazelcast 5.3.0
>  * (named-locks-redisson) redisson 3.21.3 + added bundle zip + site



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to