[ 
https://issues.apache.org/jira/browse/SUREFIRE-2182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17735997#comment-17735997
 ] 

ASF GitHub Bot commented on SUREFIRE-2182:
------------------------------------------

kwin commented on code in PR #665:
URL: https://github.com/apache/maven-surefire/pull/665#discussion_r1238087796


##########
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java:
##########
@@ -1181,6 +1181,9 @@ private RunResult executeProvider(
         } else {
             ForkConfiguration forkConfiguration = 
createForkConfiguration(platform, resolvedJavaModularityResult);
             if (getConsoleLogger().isDebugEnabled()) {
+                getConsoleLogger()
+                        .debug("Using fork starter with configuration "

Review Comment:
   Maybe "Using fork starter with configuration implementation " to be in line 
with 
https://github.com/apache/maven-surefire/blob/0998f10bb486f79f40d2d4262798b1f53a5ff286/maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java#LL2228C32-L2228C32?





> Log starter implementation on DEBUG level
> -----------------------------------------
>
>                 Key: SUREFIRE-2182
>                 URL: https://issues.apache.org/jira/browse/SUREFIRE-2182
>             Project: Maven Surefire
>          Issue Type: Improvement
>            Reporter: Konrad Windszus
>            Assignee: Konrad Windszus
>            Priority: Major
>
> In order to ease debugging classpath issues the fork configuration determined 
> by 
> [AbstractSurefireMojo.createForkConfiguration(...)|https://github.com/apache/maven-surefire/blob/0998f10bb486f79f40d2d4262798b1f53a5ff286/maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java#L2216]
>  should be logged with debug level for when using the fork starter. Similarly 
> a DEBUG log entry should be emitted when the in-process starter is being used.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to