[ 
https://issues.apache.org/jira/browse/SUREFIRE-2178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17736019#comment-17736019
 ] 

ASF GitHub Bot commented on SUREFIRE-2178:
------------------------------------------

kwin opened a new pull request, #666:
URL: https://github.com/apache/maven-surefire/pull/666

   Add the info that each item of additionalClasspathElements need to be a 
filesystem path
   
   Following this checklist to help us incorporate your 
   contribution quickly and easily:
   
    - [x] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/SUREFIRE) filed 
          for the change (usually before you start working on it).  Trivial 
changes like typos do not 
          require a JIRA issue.  Your pull request should address just this 
issue, without 
          pulling in other changes.
    - [x] Each commit in the pull request should have a meaningful subject line 
and body.
    - [x] Format the pull request title like `[SUREFIRE-XXX] - Fixes bug in 
ApproximateQuantiles`,
          where you replace `SUREFIRE-XXX` with the appropriate JIRA issue. 
Best practice
          is to use the JIRA issue title in the pull request title and in the 
first line of the 
          commit message.
    - [x] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
    - [x] Run `mvn clean install` to make sure basic checks pass. A more 
thorough check will 
          be performed on your pull request automatically.
    - [ ] You have run the integration tests successfully (`mvn -Prun-its clean 
install`).
   
   If your pull request is about ~20 lines of code you don't need to sign an
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
   please ask on the developers list.
   
   To make clear that you license your contribution under 
   the [Apache License Version 2.0, January 
2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
    - [x] I hereby declare this contribution to be licenced under the [Apache 
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   
    - [ ] In any other case, please file an [Apache Individual Contributor 
License Agreement](https://www.apache.org/licenses/icla.pdf).
   




> classpathDependencyExcludes should support classifiers
> ------------------------------------------------------
>
>                 Key: SUREFIRE-2178
>                 URL: https://issues.apache.org/jira/browse/SUREFIRE-2178
>             Project: Maven Surefire
>          Issue Type: Improvement
>          Components: classloading
>    Affects Versions: 3.1.2
>            Reporter: Konrad Windszus
>            Assignee: Konrad Windszus
>            Priority: Major
>
> Currently each item for parameter {{classpathDependencyExcludes}} 
> (https://maven.apache.org/surefire/maven-surefire-plugin/test-mojo.html#classpathDependencyExcludes)
>  only supports the format
> {code}<groupId>:<artifactId>{code}
> That makes it impossible to exclude dependencies having a classifier.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to