[
https://issues.apache.org/jira/browse/MSHARED-1275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17736358#comment-17736358
]
Herve Boutemy edited comment on MSHARED-1275 at 6/23/23 6:11 AM:
-----------------------------------------------------------------
for the goal execution use case that maven-reporting-impl fully implements,
yes, it is clear that there are 2 executions then one should be dropped: see
https://github.com/apache/maven-reporting-impl/blame/d2032091c1bd86c6f52d80a23852aff0e8c0b6ae/src/main/java/org/apache/maven/reporting/AbstractMavenReport.java#L165
where canGenerate is called first in Mojo.execute then later in generate
for site:site execution, equivalent call is done when preparing report
execution
https://github.com/apache/maven-site-plugin/blob/8c597d8db03633feb010cacb2a036b1cceb29aee/src/main/java/org/apache/maven/plugins/site/render/AbstractSiteRenderingMojo.java#L231
then yes, checking during generate() means calling twice: all has been checked
before
was (Author: hboutemy):
for the goal execution use case that maven-reporting-impl fully implements,
yes, it is clear that there are 2 executions then one should be dropped: see
https://github.com/apache/maven-reporting-impl/blame/d2032091c1bd86c6f52d80a23852aff0e8c0b6ae/src/main/java/org/apache/maven/reporting/AbstractMavenReport.java#L165
where canGenerate is called first in Mojo.execute then later in generate
for site:site execution, need to clarify yet
> MavenReport#canGenerateReport() is invoked twice
> ------------------------------------------------
>
> Key: MSHARED-1275
> URL: https://issues.apache.org/jira/browse/MSHARED-1275
> Project: Maven Shared Components
> Issue Type: Bug
> Components: maven-reporting-impl
> Affects Versions: maven-reporting-impl-4.0.0-M8
> Reporter: Michael Osipov
> Assignee: Michael Osipov
> Priority: Major
> Fix For: maven-reporting-impl-4.0.0-M9
>
>
> The mentioned method called twice for standalone *and* Maven Site Plugin use
> case in {{org.apache.maven.reporting.AbstractMavenReport.generate(Sink,
> SinkFactory, Locale)}} also both uses cases make sure that
> {{canGenerateReport()}} is invoked _before_ {{generate()}} is invoked. This
> is clearly redudant and can incur a performance overhead.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
