[ 
https://issues.apache.org/jira/browse/MSHARED-1275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17736402#comment-17736402
 ] 

Michael Osipov commented on MSHARED-1275:
-----------------------------------------

Those are exactly the spots I have identified for.

> MavenReport#canGenerateReport() is invoked twice
> ------------------------------------------------
>
>                 Key: MSHARED-1275
>                 URL: https://issues.apache.org/jira/browse/MSHARED-1275
>             Project: Maven Shared Components
>          Issue Type: Bug
>          Components: maven-reporting-impl
>    Affects Versions: maven-reporting-impl-4.0.0-M8
>            Reporter: Michael Osipov
>            Assignee: Michael Osipov
>            Priority: Major
>             Fix For: maven-reporting-impl-4.0.0-M9
>
>
> The mentioned method called twice for standalone *and* Maven Site Plugin use 
> case in {{org.apache.maven.reporting.AbstractMavenReport.generate(Sink, 
> SinkFactory, Locale)}} also both uses cases make sure that 
> {{canGenerateReport()}} is invoked _before_ {{generate()}} is invoked. This 
> is clearly redudant and can incur a performance overhead.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to