mabrarov commented on code in PR #148:
URL:
https://github.com/apache/maven-assembly-plugin/pull/148#discussion_r1253072332
##########
src/main/java/org/apache/maven/plugins/assembly/mojos/AbstractAssemblyMojo.java:
##########
@@ -430,6 +430,12 @@ public abstract class AbstractAssemblyMojo extends
AbstractMojo implements Assem
@Parameter
private String overrideGroupName;
+ /**
+ * Override of umask.
Review Comment:
Changed to
```java
/**
* Mask which is applied to permissions of files/directories before they are
put into assembly.
* If {@code null} then the mask is not explicitly configured and remains
implementation-specific.
*/
```
When this option is not configured (`null`), then the umask remains Plexus
Archiver implementation detail (which I know is `022`, but I cannot put it into
documentation of `overrideUmask` configuration option of Maven Assembly Plugin).
IMHO, we can not put `022` as default value of `overrideUmask` configuration
option of Maven Assembly Plugin, because it breaks backward compatibility (in
case someone uses another version of Plexus Archiver - the one which has
different default value of umask option - with Maven Assembly Plugin and
migrates to the new version of Maven Assembly Plugin with this pull request
integrated).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
