[ 
https://issues.apache.org/jira/browse/MJAVADOC-755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740535#comment-17740535
 ] 

ASF GitHub Bot commented on MJAVADOC-755:
-----------------------------------------

michael-o commented on code in PR #208:
URL: 
https://github.com/apache/maven-javadoc-plugin/pull/208#discussion_r1254215004


##########
src/main/java/org/apache/maven/plugins/javadoc/JavadocUtil.java:
##########
@@ -212,12 +211,12 @@ protected static String quotedArgument(String value) {
 
         if (arg != null && !arg.isEmpty()) {
             if (arg.contains("'")) {
-                arg = StringUtils.replace(arg, "'", "\\'");
+                arg = arg.replace("'", "\\'");

Review Comment:
   Why not just replace? Isn't it cheap?





> Clean up deprecated and unpreferred methods in JavadocUtil
> ----------------------------------------------------------
>
>                 Key: MJAVADOC-755
>                 URL: https://issues.apache.org/jira/browse/MJAVADOC-755
>             Project: Maven Javadoc Plugin
>          Issue Type: Dependency upgrade
>            Reporter: Elliotte Rusty Harold
>            Assignee: Elliotte Rusty Harold
>            Priority: Minor
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to