[ 
https://issues.apache.org/jira/browse/MASSEMBLY-791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17741031#comment-17741031
 ] 

ASF GitHub Bot commented on MASSEMBLY-791:
------------------------------------------

mabrarov commented on code in PR #148:
URL: 
https://github.com/apache/maven-assembly-plugin/pull/148#discussion_r1255818843


##########
src/main/java/org/apache/maven/plugins/assembly/mojos/AbstractAssemblyMojo.java:
##########
@@ -430,6 +430,15 @@ public abstract class AbstractAssemblyMojo extends 
AbstractMojo implements Assem
     @Parameter
     private String overrideGroupName;
 
+    /**
+     * Override of mask which is applied to permissions of files/directories 
before they are put into assembly.
+     * If {@code null} then the mask is not explicitly configured and remains 
implementation-specific.
+     * If invalid value is specified - like negative value - then behaviour is 
implementation specific, i.e. depends
+     * on underlying library which is used for building of assembly.
+     */
+    @Parameter
+    private Integer overrideUmask;

Review Comment:
   It overrides umask at Assembly plugin level (i.e. for all files/directories) 
which otherwise is implementation specific (can be set by Plexus Archiver under 
some conditions or can be undefined), but is still plugin configuration scoped. 
Refer to that 
[comment](https://github.com/apache/maven-assembly-plugin/pull/148#discussion_r1254863967)
 for details, please.





> fileMode not set in dependencySet creating format tar.gz
> --------------------------------------------------------
>
>                 Key: MASSEMBLY-791
>                 URL: https://issues.apache.org/jira/browse/MASSEMBLY-791
>             Project: Maven Assembly Plugin
>          Issue Type: Bug
>          Components: permissions
>    Affects Versions: 2.6
>         Environment: Linux and Windows
>            Reporter: Rick Poleshuck
>            Priority: Major
>
> The fileMode is ignored within a dependencySet while creating a tar.gz 
> archive. This works just fine in 2.4.
>     <dependencySets>
>         <dependencySet>
>             <includes>
>                 <include>com.company:dependency-artifact</include>
>             </includes>
>             <unpack>true</unpack>
>             <unpackOptions>
>                 <includes>
>                     <include>*.py</include>
>                 </includes>
>             </unpackOptions>
>             <outputDirectory/>
>             <fileMode>0750</fileMode>
>             <directoryMode>0750</directoryMode>
>         </dependencySet>
>     </dependencySets>
> </ 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to