mabrarov commented on code in PR #148:
URL:
https://github.com/apache/maven-assembly-plugin/pull/148#discussion_r1255818843
##########
src/main/java/org/apache/maven/plugins/assembly/mojos/AbstractAssemblyMojo.java:
##########
@@ -430,6 +430,15 @@ public abstract class AbstractAssemblyMojo extends
AbstractMojo implements Assem
@Parameter
private String overrideGroupName;
+ /**
+ * Override of mask which is applied to permissions of files/directories
before they are put into assembly.
+ * If {@code null} then the mask is not explicitly configured and remains
implementation-specific.
+ * If invalid value is specified - like negative value - then behaviour is
implementation specific, i.e. depends
+ * on underlying library which is used for building of assembly.
+ */
+ @Parameter
+ private Integer overrideUmask;
Review Comment:
It overrides umask at Assembly plugin level (i.e. for all files/directories)
which otherwise is implementation specific (can be set by Plexus Archiver under
some conditions or can be undefined), but is still plugin configuration scoped.
Refer to that
[comment](https://github.com/apache/maven-assembly-plugin/pull/148#discussion_r1254863967)
for details, please. `override` word means here overriding of what Plexus
Archiver does under the hood and not overriding per file/directory attribute. I
understand that `set` is more natural... do you find `umask` a better name than
`overrideUmask`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
