[ https://issues.apache.org/jira/browse/MSHARED-1290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17745665#comment-17745665 ]
ASF GitHub Bot commented on MSHARED-1290: ----------------------------------------- wborn opened a new pull request, #78: URL: https://github.com/apache/maven-filtering/pull/78 This fixes MSHARED-1290. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [x] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). > PropertyUtils cycle detection results in false positives > -------------------------------------------------------- > > Key: MSHARED-1290 > URL: https://issues.apache.org/jira/browse/MSHARED-1290 > Project: Maven Shared Components > Issue Type: Bug > Components: maven-filtering > Affects Versions: maven-filtering-3.3.1 > Reporter: Wouter Born > Priority: Major > > I upgraded the maven-assembly-plugin in one of my projects from 2.6 to 3.6.0 > and found that {{PropertyUtils}} was logging many false positives about > cycles between properties. > The cycle detection (introduced for MSHARED-417) reports false positives when > a variable occurs multiple times in a property, example: > {code:java} > depends=p1 >= ${version}, p2 >= ${version}, p3 >= ${version} > version=1.2.3 {code} > While writing a unit test to fix this, I also found that there are also cycle > false positives whenever one of the property values is the same as a property > name, example: > {code:java} > test1=${test2} > test2=test1 {code} -- This message was sent by Atlassian Jira (v8.20.10#820010)