cdprete commented on code in PR #441:
URL: https://github.com/apache/maven-site/pull/441#discussion_r1272985947


##########
content/markdown/guides/mini/guide-resolver-transport.md:
##########
@@ -99,6 +99,60 @@ for example to allow the user to tell Maven how long to wait 
before giving up on
   </servers>
 </settings>
 ```
+## Low-level Resolver configuration
+
+All configuration items mentioned in  [Configuration 
Options](https://maven.apache.org/resolver/configuration.html) 
+which is not mapped by server/configuration tag must be provided in special 
way.
+
+### System level
+
+Configuration can be provided on global level as properties in `settings.xml`
+
+```xml
+<settings>
+  <profiles>
+    <profile>
+      <id>resolver-config</id>
+      <properties>
+        <aether.dependencyCollector.impl>bf</aether.dependencyCollector.impl>
+        <!-- set preemptiveAuth for all servers -->
+        
<aether.connector.http.preemptiveAuth>true</aether.connector.http.preemptiveAuth>
+        
+        <!-- set preemptiveAuth for only for server with id - serverId -->
+        
<aether.connector.http.preemptiveAuth.serverId>true</aether.connector.http.preemptiveAuth.serverId>

Review Comment:
   > Agree about "alt format", as current is simply misleading, looks really 
like some new property. I am fine with proposed 
`aether.connector.http.preemptiveAuth[.<repositoryId>]` and also maybe 
`aether.connector.http.preemptiveAuth.$REPOSITORY_ID`? etc
   
   Seems like we replied at the same moment and I didn't see this comment.
   Both the formats are fine for me personally, as soon as end users know that 
`repositoryId` = `$REPOSITORY_ID` = `<server><id>...</id>/<server>`.
   
   Maybe `$REPOSITORY_ID` may be misleading since people may think you 
necessarily need an environment variable for it (although then it would be 
`${env-REPOSITORY_ID}`).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to