[ 
https://issues.apache.org/jira/browse/MRESOLVER-393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17749313#comment-17749313
 ] 

ASF GitHub Bot commented on MRESOLVER-393:
------------------------------------------

michael-o commented on code in PR #323:
URL: https://github.com/apache/maven-resolver/pull/323#discussion_r1279731434


##########
maven-resolver-transport-http/src/main/java/org/eclipse/aether/transport/http/HttpTransporter.java:
##########
@@ -641,6 +642,17 @@ public void handle(CloseableHttpResponse response) throws 
IOException, TransferC
                     task.setDataFile(dataFile);
                 }
             }
+            if (task.getDataFile() != null) {
+                Header lastModifiedHeader =
+                        response.getFirstHeader(HttpHeaders.LAST_MODIFIED); // 
note: Wagon also does first not last

Review Comment:
   According to https://www.rfc-editor.org/rfc/rfc9110#name-collected-abnf it 
can only appear only once anyway. Everything else is protocol violation.





> Transport HTTP does not retain last modified as sent by remote end
> ------------------------------------------------------------------
>
>                 Key: MRESOLVER-393
>                 URL: https://issues.apache.org/jira/browse/MRESOLVER-393
>             Project: Maven Resolver
>          Issue Type: Bug
>          Components: Resolver
>            Reporter: Tamas Cservenak
>            Priority: Major
>             Fix For: 1.9.15
>
>
> All files it downloads are created with "now" as timestamp.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to